chore(weave): Update ToggleButtonGroup to allow disabling individual options #3194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericakdiaz
commented
Dec 10, 2024
| if (newValue !== value) { | ||
| if ( | ||
| newValue !== value && | ||
| options.find(option => option.value === newValue)?.isDisabled !== true |
There was a problem hiding this comment.
'pointer-events-none' didn't work to prevent the onChange from firing, so moved the isDisabled check here, and fixed it below to not show a pointer cursor
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=4e5437dc17429d3409e8faf2dbbec49134912ac6 |
ericakdiaz
commented
Dec 10, 2024
| key={optionValue} | ||
| value={optionValue} | ||
| disabled={isDisabled} | ||
| asChild> |
There was a problem hiding this comment.
asChild is needed to prevent a validateDomNesting error for nested buttons, see https://www.radix-ui.com/primitives/docs/guides/composition
ericakdiaz
commented
Dec 10, 2024
| @@ -9,6 +9,7 @@ import {Tailwind} from './Tailwind'; | |||
| export type ToggleOption = { | |||
| value: string; | |||
| icon?: IconName; | |||
| isDisabled?: boolean; | |||
There was a problem hiding this comment.
added isDisabled prop to specific options
ericakdiaz
commented
Dec 10, 2024
| (icon | ||
| ? 'gap-6 px-10 py-8 text-base' | ||
| : 'px-12 py-8 text-base'), | ||
| (isDisabled || optionIsDisabled) && 'cursor-auto opacity-35', |
There was a problem hiding this comment.
checks optionIsDisabled and changes pointer-events-none to cursor-auto
ssisk
approved these changes
Dec 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes nested button error in console, and fixes disabling individual options.
Testing
Tested on historic usage chart here https://github.com/wandb/core/pull/26192